diff --git a/spring-boot-project/spring-boot-dependencies/pom.xml b/spring-boot-project/spring-boot-dependencies/pom.xml index e86246a211..df5d29db1e 100644 --- a/spring-boot-project/spring-boot-dependencies/pom.xml +++ b/spring-boot-project/spring-boot-dependencies/pom.xml @@ -175,7 +175,7 @@ 3.0.1.RELEASE 8.5.29 4.0.5 - 1.4.23.Final + 1.4.24.Final 3325375 0.35 1.6.3 diff --git a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/undertow/UndertowServletWebServerFactoryTests.java b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/undertow/UndertowServletWebServerFactoryTests.java index ebc10d2988..e031675e79 100644 --- a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/undertow/UndertowServletWebServerFactoryTests.java +++ b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/embedded/undertow/UndertowServletWebServerFactoryTests.java @@ -28,6 +28,7 @@ import java.util.Map; import java.util.Set; import java.util.concurrent.atomic.AtomicReference; +import javax.net.ssl.SSLException; import javax.net.ssl.SSLHandshakeException; import io.undertow.Undertow.Builder; @@ -213,7 +214,7 @@ public class UndertowServletWebServerFactoryTests new String[] { "TLS_EMPTY_RENEGOTIATION_INFO_SCSV" }); } - @Test(expected = SSLHandshakeException.class) + @Test(expected = SSLException.class) public void sslRestrictedProtocolsECDHETLS1Failure() throws Exception { testRestrictedSSLProtocolsAndCipherSuites(new String[] { "TLSv1" }, new String[] { "TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256" }); @@ -231,7 +232,7 @@ public class UndertowServletWebServerFactoryTests new String[] { "TLS_RSA_WITH_AES_128_CBC_SHA256" }); } - @Test(expected = SSLHandshakeException.class) + @Test(expected = SSLException.class) public void sslRestrictedProtocolsRSATLS11Failure() throws Exception { testRestrictedSSLProtocolsAndCipherSuites(new String[] { "TLSv1.1" }, new String[] { "TLS_RSA_WITH_AES_128_CBC_SHA256" }); diff --git a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/reactive/server/AbstractReactiveWebServerFactoryTests.java b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/reactive/server/AbstractReactiveWebServerFactoryTests.java index b4575a2869..6fa3cc46f5 100644 --- a/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/reactive/server/AbstractReactiveWebServerFactoryTests.java +++ b/spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/reactive/server/AbstractReactiveWebServerFactoryTests.java @@ -34,7 +34,6 @@ import io.netty.handler.codec.http.HttpHeaderNames; import io.netty.handler.codec.http.HttpResponse; import io.netty.handler.ssl.SslProvider; import io.netty.handler.ssl.util.InsecureTrustManagerFactory; -import org.assertj.core.api.Assumptions; import org.junit.After; import org.junit.Rule; import org.junit.Test; @@ -45,7 +44,6 @@ import reactor.ipc.netty.http.client.HttpClientOptions; import reactor.test.StepVerifier; import org.springframework.boot.testsupport.rule.OutputCapture; -import org.springframework.boot.web.embedded.undertow.UndertowReactiveWebServerFactory; import org.springframework.boot.web.server.Compression; import org.springframework.boot.web.server.Ssl; import org.springframework.boot.web.server.WebServer; @@ -154,8 +152,7 @@ public abstract class AbstractReactiveWebServerFactoryTests { } @Test - public void sslWantsClientAuthenticationSucceedsWithoutClientCertificate() - throws Exception { + public void sslWantsClientAuthenticationSucceedsWithoutClientCertificate() { Ssl ssl = new Ssl(); ssl.setClientAuth(Ssl.ClientAuth.WANT); ssl.setKeyStore("classpath:test.jks"); @@ -205,11 +202,7 @@ public abstract class AbstractReactiveWebServerFactoryTests { } @Test - public void sslNeedsClientAuthenticationFailsWithoutClientCertificate() - throws Exception { - // Ignored for Undertow, see https://github.com/reactor/reactor-netty/issues/257 - Assumptions.assumeThat(getFactory()) - .isNotInstanceOf(UndertowReactiveWebServerFactory.class); + public void sslNeedsClientAuthenticationFailsWithoutClientCertificate() { Ssl ssl = new Ssl(); ssl.setClientAuth(Ssl.ClientAuth.NEED); ssl.setKeyStore("classpath:test.jks");