Commit Graph

20241 Commits (1c90a89acde0745a874f13c2b1ce0d3f88ededf9)
 

Author SHA1 Message Date
Brian Clozel 99656b9dd8 Merge branch '2.1.x' 6 years ago
Brian Clozel 72c8e5d366 Collect HTTP trace at commit time for WebFlux
Prior to this commit, the `HttpTraceWebFilter` would collect the
response information (status and headers) for tracing purposes, after
the handling chain is done with the exchange - inside a
`doAfterSuccessOrError`.

Once the handler has processed the exchange, there is no strong
guarantee about the HTTP resources being still present. Depending on the
web server implementation, HTTP resources (including HTTP header maps)
might be recycled, because pooled in the first place.

This commit moves the collection and processing of the HTTP trace right
before the response is committed. This removes the need to handle
special cases with exceptions, since by that time all exception handlers
have processed the response and the information that we extract is the
information that's about to be written to the network.

Fixes gh-15819
6 years ago
Brian Clozel e8fef97335 Merge branch '2.1.x' 6 years ago
Brian Clozel cba6079b7b Log unhandled server exceptions in WebFlux
Prior to this commit, errors unhandled by custom `WebExceptionHandler`
and resulting in an HTTP 500 status would not be logged at ERROR level,
giving no information to developers about the actual exception.

This commit ensures that such exceptions are logged at the ERROR level
with their exception. By the time the exception hits the
`DefaultErrorWebExceptionHandler`, if the response is already committed
or if the exception is due to a client disconnecting, the error is
delegated to Framework support as Spring Boot won't be able to render an
error page as expected.

Fixes gh-15769
6 years ago
Johnny Lim 4aff659c18 Polish
See gh-15873
6 years ago
Stephane Nicoll 380d7ec01c Merge branch '2.1.x' 6 years ago
Stephane Nicoll 64cb4e2043 Merge pull request #15873 from izeye
* pr/15873:
  Polish
6 years ago
Johnny Lim 885c28891b Polish
Closes gh-15873
6 years ago
Stephane Nicoll 9eccf6c367 Merge branch '2.1.x' 6 years ago
Stephane Nicoll 7bdcee5e3d Merge pull request #15871 from dreis2211
* pr/15871:
  Fix assertion
6 years ago
dreis2211 48295e16fc Fix assertion
Closes gh-15871
6 years ago
Madhura Bhave e3fad4e973 Merge branch '2.1.x' 6 years ago
Madhura Bhave dc31f617b3 Document limitations of YAML documents & profile-specific files
Fixes gh-15790
6 years ago
Andy Wilkinson 88f563ab4f Merge branch '2.1.x' 6 years ago
Andy Wilkinson 688eb894d0 Start building against Micrometer 1.1.3 snapshots
See gh-15869
6 years ago
Andy Wilkinson 4efca4a455 Start building against Spring Session Bean-SR3 snapshots
See gh-15868
6 years ago
Andy Wilkinson 01693bb1fd Start building against Spring Kafka 2.2.4 snapshots
See gh-15867
6 years ago
Andy Wilkinson 474a706cc3 Start building against Spring Integration 5.1.3 snapshots
See gh-15866
6 years ago
Andy Wilkinson 245d3cf9f4 Start building against Spring AMQP 2.1.4 snapshots
See gh-15865
6 years ago
Andy Wilkinson 96cf7b1e64 Start building against Spring Data Lovelace-SR5 snapshots
See gh-15864
6 years ago
Andy Wilkinson 333fe77f58 Start building against Spring Security 5.1.4 snapshots
See gh-15863
6 years ago
Andy Wilkinson 1f4927b65d Start building against Spring Framework 5.1.5 snapshots
See gh-15862
6 years ago
Stephane Nicoll 6516d95ff5 Merge pull request #15853 from kedar-joshi
* pr/15853:
  Polish contribution
  Polish
6 years ago
Stephane Nicoll b169406bbe Polish contribution
Closes gh-15853
6 years ago
Kedar Joshi b43718c360 Polish
See gh-15853
6 years ago
Andy Wilkinson ecb7e240eb Merge branch '2.1.x' 6 years ago
Andy Wilkinson 59c66eaf41 Correct documented path for locked synchronizer's identity hashcode
Closes gh-15847
6 years ago
Andy Wilkinson ebcc53a9b7 Include tasks with custom triggers in scheduledtasks endpoint output
Closes gh-15815
6 years ago
Andy Wilkinson 89bf486d0c Merge branch '2.1.x' 6 years ago
Andy Wilkinson 1f67707509 Fix cast in TestRestTemplateContextCustomizer
Closes gh-15843
6 years ago
Andy Wilkinson b3abd25e22 Merge branch '2.1.x' 6 years ago
Andy Wilkinson 8a7958ef55 Do not use reflection to fall back to JDKs jar URLStreamHandler
Closes gh-15844
6 years ago
Andy Wilkinson 45cc649c7d Merge branch '2.1.x' 6 years ago
Andy Wilkinson 82bc87560c Use AssertJ’s exception assertions rather than fail
Closes gh-15761
6 years ago
Stephane Nicoll a84a6c34ba Merge branch '2.1.x' 6 years ago
Stephane Nicoll 9357a92503 Add reference to Codecentric's SOAP Web Services starter 6 years ago
Andy Wilkinson 342bced125 Merge branch '2.1.x' 6 years ago
Andy Wilkinson 2650a07dc9 Leave module-info.class in root of archive when repackaging
Closes gh-15810
6 years ago
Stephane Nicoll b4e890c3be Merge pull request #15754 from izeye
* pr/15754:
  Polish contribution
  Polish SessionConfigurationImportSelector.selectImports()
6 years ago
Stephane Nicoll 5269ea5536 Polish contribution
Closes gh-15754
6 years ago
Johnny Lim 6603033bbc Polish SessionConfigurationImportSelector.selectImports()
See gh-15754
6 years ago
Stephane Nicoll 002fa405a8 Merge branch '2.1.x' 6 years ago
Stephane Nicoll c84a0f530b Merge pull request #15798 from ayudovin
* pr/15798:
  Polish "Inject Map directly rather than via ObjectProvider"
  Inject Map directly rather than via ObjectProvider
6 years ago
Stephane Nicoll ede23caace Polish "Inject Map directly rather than via ObjectProvider"
Closes gh-15798
6 years ago
ayudovin 3a2e85ce75 Inject Map directly rather than via ObjectProvider
See gh-15798
6 years ago
Stephane Nicoll 9d609ab1ba Merge pull request #15778 from ayudovin
* pr/15778:
  Polish "Handle AccessControlException in JspTemplateAvailabilityProvider"
  Handle AccessControlException in JspTemplateAvailabilityProvider
6 years ago
Stephane Nicoll c5675de666 Polish "Handle AccessControlException in JspTemplateAvailabilityProvider"
Closes gh-15778
6 years ago
ayudovin 81273bdf9a Handle AccessControlException in JspTemplateAvailabilityProvider
See gh-15778
6 years ago
Stephane Nicoll 5e2d5959f3 Polish 6 years ago
Andy Wilkinson 9e43ee1d2c Merge pull request #15782 from Christoph Dreiss
* gh-15782:
  Optimize ConfigurationPropertyName

Closes gh-15782
6 years ago