Commit Graph

19112 Commits (bf1c18537779c44174725f79209f7bf6135f9c7d)

Author SHA1 Message Date
Andy Wilkinson b192c29edb Use AOT's outputs to configure source set's inputs
Closes gh-32919
2 years ago
Andy Wilkinson 0103e24bbb Stop configuring AOT-generated classes as output of AOT source set
Closes gh-32940
2 years ago
Andy Wilkinson 2bb9b2640e Separate classpath of AOT tasks from source sets they populate
Closes gh-32930
2 years ago
Phillip Webb 2b5a29d514 No longer log hostname during application start
Remove hostname logging since `InetAddress.getLocalHost().getHostName()`
causes a network lookup and can take a long time.

Closes gh-32908
2 years ago
Scott Frederick c81ebf63d9 Use ApplicationContextFailureProcessor to log report on failure
Closes gh-31793
2 years ago
Moritz Halbritter 6a138e1753 Polish 2 years ago
Moritz Halbritter 4fef5291bf Fix build
Commit 29f085bd1a690ff7281e00b3a925e1160850ffbb in Spring Framework
automatically registers hints for enclosing directories. This fixes the
tests to use a contains instead of exact match.
2 years ago
Moritz Halbritter 5e034eab59 Revert "Fix build"
This reverts commit ec0d598ba4.
2 years ago
Moritz Halbritter dd2bec267c Revert "Fix build"
This reverts commit 50599c5046.
2 years ago
Moritz Halbritter 50599c5046 Fix build
Commit 29f085bd1a690ff7281e00b3a925e1160850ffbb in Spring Framework
automatically registers hints for enclosing directories. This fixes the
tests to expect hints for those directories as well.
2 years ago
Moritz Halbritter ec0d598ba4 Fix build
Commit 29f085bd1a690ff7281e00b3a925e1160850ffbb in Spring Framework
automatically registers hints for enclosing directories. This fixes the
tests to expect hints for those directories as well.
2 years ago
Moritz Halbritter 5bf088d88b Add runtime hints for Liquibase migration file
Closes gh-32926
2 years ago
Moritz Halbritter 5d1ff17a0a Add Micrometer Observability documentation
Closes gh-32833
Closes gh-32912
2 years ago
Phillip Webb 9856286a2d Refine actuator httpexhanges naming
See gh-32885
2 years ago
Andy Wilkinson 29f7a596fe Polish 2 years ago
Phillip Webb 3e50836b1a Rename httptrace endpoint and related classes to httpexchanges
Rename `/actuator/httptrace` to `/actuator/httpexchanges` to better
describe its purpose and to remove confusion with distribute tracing.

This change also takes the opportunity to improve the code by making
the `HttpExchange` class (previously `HttpTrace`) fully immutable.

Closes gh-32885

Co-authored-by: Andy Wilkinson <wilkinsona@vmware.com>
2 years ago
Johnny Lim 8d17d2d443 Handle null span in LazyTracingSpanContextSupplier consistently
See gh-32817
2 years ago
Andy Wilkinson 67e4ac4f1e Remove stale reference to MetricsWebFilter from the docs
Closes gh-32909
2 years ago
Moritz Halbritter 40e2d0b8cd Remove mention of the Infinispan Spring Boot starter
The starter is not yet Spring Boot 3 compatible.

Closes gh-32896
2 years ago
Johnny Lim 5067aab552 Polish
See gh-32840
2 years ago
Johnny Lim 7dd083ad69 Polish "Remove spring.xml.ignore flag usages"
See gh-32846
2 years ago
Andy Wilkinson 1cb149596d Add json starter so that Elasticsearch uses Jackson mapper by default
Closes gh-32906
2 years ago
Andy Wilkinson b9e176ce1a Inject Jackson modules rather than retrieving them manually
Fixes gh-32863
2 years ago
Moritz Halbritter 65c68ba64e Reinstate old flyway bean method
Closes gh-32849
2 years ago
Moritz Halbritter cd5d2ad3e8 Revert "Extract Flyway configuration mapping in separate class"
This reverts commit cf4117856b.
2 years ago
Moritz Halbritter cf4117856b Extract Flyway configuration mapping in separate class
Closes gh-32849
2 years ago
Marcin Grzejszczak b753170807 Add missing BaggageTextMapPropagator for OTel W3C
Without this change we're missing the BaggageTextMapPropagator for
OTel. This means that we're not propagating remote-fields
(only baggage via the 'baggage' field).

With this change we're adding the missing propagator as
THE LAST entry in the composite TextMapPropagator. It has to be
last cause with the latest Snapshots of Micrometer Tracing it
will append the remote field baggage to existing baggage in the
context extracted via the W3CBaggagePropagator.

See gh-32898
2 years ago
Moritz Halbritter 1f0cf1ac2b Make EmbeddedDatabaseConnection GraalVM compatible
Without those changes, if @AutoConfigureTestDatabase is used, the
native image build process fails with:

  EmbeddedDatabaseConnection was unintentionally initialized at build
  time.

Closes gh-32865
2 years ago
Scott Frederick eeac08e50e Remove references to WebSecurityConfigurerAdapter from javadoc
Closes gh-32879
2 years ago
Moritz Halbritter 0985e3d237 Add resource hint for banner.txt
Closes gh-32882
2 years ago
Phillip Webb a59b6cb1f3 Polish 2 years ago
Phillip Webb 0f405c06bf Merge branch '2.7.x' 2 years ago
Phillip Webb f44531a7a2 Merge branch '2.6.x' into 2.7.x 2 years ago
Phillip Webb 92b513dc8d Polish 2 years ago
Phillip Webb 4be3218cb6 Merge branch '2.7.x' 2 years ago
Phillip Webb c8676a81de Merge branch '2.6.x' into 2.7.x 2 years ago
Phillip Webb d7ac20cd6c Update copyright year of changed files 2 years ago
Phillip Webb 9505673d6f Ensure application event listeners are always refreshed
Update `EventPublishingRunListener` to ensure that application event
listeners are always refreshed before multicasting initial events.

Prior to this commit, refreshing occurred after multicasting which
meant that listeners added by a different `SpringApplicationRunListener`
would not be picked up. This caused properties from tests that have
`UseMainMethod` set to `ALWAYS` or `WHEN_AVAILABLE` to be missing.

Fixes gh-32860
2 years ago
Phillip Webb 159910b0d9 Polish 2 years ago
Andy Wilkinson e6c37d698f Reinstate support for read timeouts with RestTemplateBuilder
Refactor the way `ClientHttpRequestFactory` instances are created in
order to support setting read timeouts.

Prior to this commit, the reflection based approach would call
`setReadTimeout`. As of Spring Framework 6.0, the
`HttpComponentsClientHttpRequestFactory` class no longer supports this
approach. The timeout must be set on the `HttpClientConnectionManager`
used in the `HttpClient` which can be passed in to the constructor.

In order to support this approach, the `ClientHttpRequestFactory` can
now be created using a `Function` rather than a `Supplier`. The
function accepts a `ClientHttpRequestFactorySettings` which provides
the timeout settings to apply.

The `ClientHttpRequestFactories` utility class provides methods to
create `ClientHttpRequestFactory` instances that respect the settings.
Whenever possible, these are created without using reflection.

Fixes gh-32857

Co-authored-by: Phillip Webb <pwebb@vmware.com>
2 years ago
Scott Frederick c22e76632c Add Build-Jdk-Spec to jar and war manifest when building with Gradle
This commit adds a `Build-Jdk-Spec` attribute to the manifest in a
jar or war file built with the Spring Boot Gradle plugin. This
aligns the Gradle plugin's behavior with the default Maven plugin
behavior.

This removes the need to set a `BP_JVM_VERSION` environment variable
when invoking Cloud Native Buildpacks, as the Paketo buildpacks will
honor `Build-Jdk-Spec` in a jar or war manifest to determine the
default JVM version.

Fixes gh-32829
2 years ago
Moritz Halbritter 383d6c897f Remove reflection for SimpleRequestExpectationManager creation
Closes gh-32867
2 years ago
Moritz Halbritter 9ee3fd0b0b Disable HttpGraphQlTesterContextCustomizer after AOT processing
After AOT processing, a HttpGraphQlTester bean will be defined directly
so the context customizer that initiates its registration is not
needed.

Closes gh-32872
2 years ago
Andy Wilkinson 99edda735e Polish 2 years ago
Moritz Halbritter b014039a34 Disable WebTestClientContextCustomizer after AOT processing
After AOT processing, a WebTestClient bean will be defined directly
so the context customizer that initiates its registration is not
needed.

Closes gh-32859
2 years ago
Moritz Halbritter f2c004f604 Remove reflection in OutputCaptureExtension
Closes gh-32870
2 years ago
Moritz Halbritter 512a4c7544 Revert "Register runtime hints for OutputCapture"
This reverts commit 35abc3a6dc.
2 years ago
Moritz Halbritter 35abc3a6dc Register runtime hints for OutputCapture
Closes gh-32870
2 years ago
Andy Wilkinson f11945b961 Start building against Spring Framework 6.0.0-RC3 snapshots
See gh-32856
2 years ago
Andy Wilkinson b7fb345709 Revert workaround for multiple ImportRuntimeHints
Closes gh-32830
2 years ago
Andy Wilkinson b78e7b5ac7 Disable TestRestTemplateContextCustomizer after AOT processing
After AOT processing, a TestRestTemplate bean will be defined
directly so the context customizer that initiates its registration is
not needed. We'd already disabled the registrar but this is
insufficient in Graal 22.3 which fails fast when the customizer tries
to reference the registrar.

Fixes gh-32848
2 years ago
Moritz Halbritter 605dd3d4bd Polish docs 2 years ago
Andy Wilkinson 9e6259cd37 Remove development-only dependencies from native image classpath
Fixes gh-32843
2 years ago
Andy Wilkinson b0b2818f0b Improve type discovery in Logback AOT contribution
Logback can infer the Java class to which an XML tag should be mapped
by looking for a setter method on the class to which the parent tag
was mapped. This commits ensures that reflection hints are added for
such classes.

Fixes gh-32839
2 years ago
Andy Wilkinson eebe23a081 Make all AOT-generated resources available to native-compile
Fixes gh-32841
2 years ago
Moritz Halbritter ff6d9aa881 Polish "Add micrometer tracing documentation" 2 years ago
Andy Wilkinson bed313746b Correct property names to align with changes in 3.0
See gh-32837
2 years ago
Johnny Lim fc61690675 Add missing @Test to sanitizeLists()
See gh-32792
2 years ago
Andy Wilkinson a606b26920 Merge branch '2.7.x'
Closes gh-32837
2 years ago
Andy Wilkinson 032487117b Merge branch '2.6.x' into 2.7.x
Closes gh-32836
2 years ago
Andy Wilkinson fe51e03019 Support IPv6 addresses in spring.redis.sentinel.nodes
Fixes gh-32762
2 years ago
Moritz Halbritter e999513838 Add micrometer tracing documentation
Closes gh-30658
2 years ago
Sébastien Deleuze 4e131bd627 Provide a workaround to allow multiple @ImportRuntimeHints
Provide a workaround for spring-projects/spring-framework#29361 so
that multiple `@ImportRuntimeHints` can be used in a type hierarchy.

The commit should cover Actuator web endpoint use cases with the
exception of Cloud Foundry endpoints which are not possible due to
package access issues.

See gh-29361
2 years ago
Phillip Webb ea094ddba6 Fix package tangles caused by ConfigurationProperties hints
Relocate `ConfigurationPropertiesReflectionHintsProcessor` and refactor
it to be a general purpose `BindableRuntimeHintsRegistrar`.

Prior to this commit, `ConfigurationPropertiesReflectionHintsProcessor`
was used to declare binding hints for classes that were bound, but
might be `@ConfigurationProperties`. By moving and renaming the class,
it's now better aligned to the way it's used.

Support for `@NestedConfigurationProperties` has been implemented by
adding a `@Nestable` meta-annotation. This allow us to create the
appropriate hints, without the `Binder` needing to be directly aware of
the `@NestedConfigurationProperties` annotation.

Closes gh-32815
2 years ago
Phillip Webb eb1d72e7b7 Merge branch '2.7.x' 2 years ago
Phillip Webb d8c4aec946 Merge branch '2.6.x' into 2.7.x 2 years ago
Phillip Webb 1a14f39f83 Polish 2 years ago
Phillip Webb 7db93aeb90 Merge branch '2.7.x'
Closes gh-32827
2 years ago
Phillip Webb 1c7bff7cc1 Merge branch '2.6.x' into 2.7.x
Closes gh-32826
2 years ago
Phillip Webb 463a614d27 Fix package tangle between SpringApplication and Environment types
Update `SpringApplication` so that it no longer directly decides the
type of `Environment` that should be created.

Closes gh-32825
2 years ago
Scott Frederick 072ce5c151 Fix versions in documentation links
Fixes gh-32772
2 years ago
Scott Frederick b78b22b6f6 Allow Gradle task property to be set with String or enum value
See gh-32769
2 years ago
Phillip Webb c53c8c84b8 Fix annotation processor to deal with relocated @ConstructorBinding
Update `ConfigurationMetadataAnnotationProcessor` to use the correct
location for the `@ConstructorBinding` annotation and to deal with
finding it as a meta-annotation.

Closes gh-32660
2 years ago
Scott Frederick bdedae21c0 Polish native image documentation
See gh-32582
2 years ago
Stephane Nicoll 010891a3c6 Merge branch '2.7.x'
Closes gh-32821
2 years ago
Stephane Nicoll 7bd9754ce1 Merge branch '2.6.x' into 2.7.x
Closes gh-32820
2 years ago
James Seung Hyun Son 5e0a67ac66 Fix typos in logging.adoc
See gh-32812
2 years ago
Stephane Nicoll 74a8eb7160 Merge branch '2.7.x'
Closes gh-32819
2 years ago
Stephane Nicoll 13691f27bd Merge branch '2.6.x' into 2.7.x
Closes gh-32818
2 years ago
Stephane Nicoll 4d7cb7144e Upgrade copyright year of changed files
See gh-32644
2 years ago
Ada-Claire c5a1944267 Harmonize ConfigurationProperties code samples
Rename the SomeProperties class so that it is consistent with other
examples given within the Type-safe Configuration Properties. This
ensures that readers can intuitively draw the conclusion that the
MyProperties class is annotated with ConfigurationProperties.

See gh-32644
2 years ago
Andy Wilkinson 482eb49391 Support <import> in logback.xml during AOT processing
See gh-32756
2 years ago
Brian Clozel 685fa900f8 Auto-configure Observation instrumentation for WebFlux
Prior to this commit, Spring Boot would offer a specific Metrics
instrumentation for WebFlux applications through a `WebFilter` and
custom Tag providers.

As of Spring Framework 6.0, the Observation instrumentation is done
directly in WebFlux, also with a `WebFilter`. While this allows both
metrics and traces, some features cannot be supported in the same way
with this new infrastructure.
The former `WebFilter` has been removed and the Tagging infrastructure
deprecated in favor of custom Observation conventions. This commit
provides an adapter layer so that developers can refactor their custom
tagging solution to the convention way, during the deprecation phase,
without losing any feature.

Closes gh-32539
2 years ago
Stephane Nicoll cda63b541f Upgrade to Spring Framework 6.0.0-RC2
Closes gh-32696
2 years ago
Andy Wilkinson 26e747d2db Fix package tangle in spring-boot-gradle-plugin
Closes gh-32814
2 years ago
Stephane Nicoll 04d6840ff3 Polish "Upgrade to Spring Security 6.0.0-RC1"
See gh-32604
2 years ago
Stephane Nicoll d8ec24b542 Upgrade to Spring Batch 5.0.0-RC1
Closes gh-32618
2 years ago
Stephane Nicoll d39144232f Upgrade to Spring Session 3.0.0-RC1
Closes gh-32606
2 years ago
Moritz Halbritter 1635f61368 Update GraalVM requirement to 22.3
See gh-32813
2 years ago
Phillip Webb 73a34b6c0a Fix checkstyle issues
See gh-32582
2 years ago
Sébastien Deleuze 3002779195 Remove LogbackConfigurationAotContribution from native image
Remove `LogbackConfigurationAotContribution` from the reachable
code path from a native image POV.

See gh-32793
2 years ago
Phillip Webb fb736e8427 Add native image reference documentation
Update reference documentation with a new "native image" section.

This commit includes some work derived from the "Spring Native"
project documentation written by Andy Clement, Sébastien Deleuze,
Filip Hanik, Dave Syer, Esteban Ginez, Jay Bryant, Brian Clozel,
Stéphane Nicoll, and Josh Long.

Closes gh-32582

Co-authored-by: Moritz Halbritter <mkammerer@vmware.com>
2 years ago
Phillip Webb 0219b222c2 Merge branch '2.7.x' 2 years ago
Phillip Webb d3750c4991 Merge branch '2.6.x' into 2.7.x 2 years ago
Phillip Webb c416c17fe8 Polish documentation title case 2 years ago
Scott Frederick 8acf9afccb Use String instead of enum for Gradle task Property
See gh-32769
2 years ago
Brian Clozel 9948fc3e39 Use GraphQL Observation instrumentation
This commit migrates the existing metrics support (added in #29140) to
the new `Observation` instrumentation contributed in
spring-projects/spring-graphql#501.

We cannot have a smoother migration path here as the instrumentation
does not use the same context information for metadata extraction.

Closes gh-32794
2 years ago
Stephane Nicoll 1822ce1ef3 Upgrade to Mockito 4.8.1
Closes gh-32799
2 years ago
Stephane Nicoll 5cc9527fde Upgrade to Infinispan 14.0.1.Final
Closes gh-32798
2 years ago
Stephane Nicoll 8a9b679c4c Upgrade to Groovy 4.0.6
Closes gh-32797
2 years ago
Stephane Nicoll 973121db5d Upgrade to Flyway 9.5.0
Closes gh-32796
2 years ago
Madhura Bhave ce3c933f77 Adapt to Spring Security changes
Closes gh-32604
2 years ago
Phillip Webb 2e74878ba4 Downgrade to OpenSAML 4.0.1
See gh-32604
2 years ago
Madhura Bhave cedd553b83 Remove error page security filter
Spring Security now re-applies the authorization rules
to the error page by default. Additionally, it configures
RequestAttributeSecurityContextRepository as the default for
stateless applications allowing those applications to have access
to the original authentication during an error dispatch.

Closes gh-31703
2 years ago
Andy Wilkinson 8621be6bba Make consistent use of Property for Gradle task configuration
Closes gh-32769
2 years ago
Brian Clozel e5c12c2b56 Move HTTP client observation auto-configuration
This commit moves the observation auto-configuration from the metrics
package to the observation package for consistency.

See gh-32484
See gh-32518
2 years ago
Brian Clozel b2fe807d47 Move MVC metrics to Observation auto-configuration
This commit moves the entire Metrics auto-configuration for Spring MVC
to the new `Observation` API and the instrumentation contributed in
Spring Framework.

Closes gh-32538
2 years ago
Andy Wilkinson e6c69061b5 Upgrade to Jackson 2.14.0-rc2
Closes gh-32771
2 years ago
Andy Wilkinson 6f787c4b79 Upgrade to Infinispan 13.0.12.Final
Closes gh-32788
2 years ago
Andy Wilkinson 3aa835845e Upgrade to Glassfish JAXB 2.3.7
Closes gh-32787
2 years ago
Andy Wilkinson ba02a64743 Upgrade to Dependency Management Plugin 1.0.15.RELEASE
Closes gh-32786
2 years ago
Andy Wilkinson 65bdcdb2a5 Upgrade to Glassfish JAXB 2.3.7
Closes gh-32785
2 years ago
Andy Wilkinson 02760ffee4 Upgrade to Dependency Management Plugin 1.0.15.RELEASE
Closes gh-32784
2 years ago
Andy Wilkinson 391e2f7a26 Make META-INF/spring/logback-pattern-rules repeatable
See gh-32756
2 years ago
Andy Wilkinson a87aca2744 Merge branch '2.7.x'
Closes gh-32782
2 years ago
Andy Wilkinson a19e394ebb Merge branch '2.6.x' into 2.7.x
Closes gh-32781
2 years ago
Henning Poettker 4ed072a06b Upgrade MySQL Connector/J and use new Maven identifiers
See gh-32747
2 years ago
Stephane Nicoll b69cf43ec0 Revert "Upgrade to Spring Session 2022.0.0-RC1"
This reverts commit e7b3114db7.
2 years ago
Stephane Nicoll e7b3114db7 Upgrade to Spring Session 2022.0.0-RC1
Closes gh-32606
2 years ago
Phillip Webb 43a44006c9 Update getting started documentation to use @SpringBootApplication
Closes gh-32780
2 years ago
Phillip Webb 8dadf86f93 Merge branch '2.7.x'
Closes gh-32778
2 years ago
Phillip Webb fcaac2b343 Merge branch '2.6.x' into 2.7.x
Closes gh-32777
2 years ago
Phillip Webb 2c7114fa17 Polish 'Use exclamation character for the document separator prefix'
See gh-32521
2 years ago
Guirong Hu 33e379c4a2 Use exclamation character for the document separator prefix
See gh-32521
2 years ago
Phillip Webb 07dd388b58 Merge branch '2.7.x'
Closes gh-32776
2 years ago
Phillip Webb 8dec296dfd Merge branch '2.6.x' into 2.7.x
Closes gh-32775
2 years ago
Phillip Webb de111dba5c Polish 'Add DataSize serializer for configprops endpoint'
See gh-32645
2 years ago
Guirong Hu 3b25132e38 Add DataSize serializer for configprops endpoint
See gh-32645
2 years ago
Phillip Webb 02cd910f5a Merge branch '2.7.x'
Closes gh-32774
2 years ago
Phillip Webb fbd416adc6 Merge branch '2.6.x' into 2.7.x
Closes gh-32773
2 years ago
Phillip Webb b02c702ad1 Polish 'Use more specific bean method return types in KafkaAutoConfiguration'
See gh-32770
2 years ago
yuanhao18 c498ad0320 Use more specific bean method return types in KafkaAutoConfiguration
Update `KafkaAutoConfiguration` so that more specific bean types are
returned.

See gh-32770
2 years ago
Scott Frederick 76c7263eff Provide default groupId for AOT processing
Framework requires the `groupId` passed to the AOT processing
to be non-empty, so a default should be used if the build
system does not provide a value.

See gh-32696
2 years ago
Andy Wilkinson 9d07a09ed4 Upgrade to Spring Integration 6.0.0-RC1
Closes gh-32619
2 years ago
Andy Wilkinson 60112e7d90 Upgrade to Spring WS 4.0.0-RC1
Closes gh-32621
2 years ago
Andy Wilkinson d20f582493 Upgrade to Spring GraphQL 1.0.0-RC1
Closes gh-32605
2 years ago
Andy Wilkinson 4a76fbf93c Support logback.xml in a native image
Closes gh-32756
2 years ago
Phillip Webb cb48674536 Switch Java versions used in documentation
See gh-32746
2 years ago
Phillip Webb 7d03a201c0 Switch Java version displayed in documentation
Closes gh-32746
2 years ago
Phillip Webb 45ce096b6b Replace our TestCompiler with Spring Framework's version
Replace the last use of our `TestCompiler` with Spring Framework's
version.

See gh-31266
2 years ago
Andy Wilkinson 7bae02be2d Adapt to breaking changes to AotProcessor settings
See gh-32696
2 years ago
Stephane Nicoll d53c2b25d0 Upgrade to Spring Retry 2.0.0-RC2
Closes gh-32600
2 years ago
Stephane Nicoll 4b778ff4c1 Polish Maven documentation to mention native profile 2 years ago
Stephane Nicoll f0d1eb7891 Configure the Native buildpack when enabling the native Maven profile
This commit makes sure that the Native Cloud Native Buildpacks is
configured when the native Maven profile is enabled. Doing so lets
users generate a native image with a single command-line by default:

$ ./mvnw -Pnative spring-boot:build-image

Closes gh-32764
2 years ago
Moritz Halbritter 8cd9f49fad Add runtime hints for ConfigDataProperties
Closes gh-32608
2 years ago
Andy Wilkinson 2dacddb4d7 Make bootBuildImage produce native image when NBT plugin is applied
Closes gh-32768
2 years ago
Andy Wilkinson 2c756ea874 Use collectReachabilityMetadata task to add metadata to bootJar
Closes gh-32737
2 years ago
Moritz Halbritter b986a9b12e Add Flyway native-image support
The ResourceProviderCustomizer, which is used by FlywayAutoConfiguration
gets replaced with NativeImageResourceProviderCustomizer when running
in AOT mode. The NativeImageResourceProvider does the heavy lifting when
running in a native image: it uses PathMatchingResourcePatternResolver
to find the migration files.

Closes gh-31999
2 years ago
Andy Wilkinson 3acdf590b7 Upgrade to Dependency Management Plugin 1.1.0
Closes gh-32760
2 years ago
Andy Wilkinson 93436f29dd Correct assertion in test for member with private constructor
See gh-32639
2 years ago