Do not expose servlet locations in WebFlux
The `spring.resources.static-locations` key (see `ResourceProperties`) lists many locations by default, including `"classpath:/static"` and `"/"`. The latter is about exposing resources located in the root servlet location. Reactive web applications don't depend on a Servlet-related `ApplicationContext`/`ResourceLoader`, so `"/"` is then resolved as `"classpath:/"`, which exposes the whole classpath. To avoid such situations, the `GenericReactiveWebApplicationContext` overrides the `getResourceByPath(String path)` method and always returns non existent resources if the path starts with `"/"`. Fixes gh-8485pull/8718/merge
parent
00021dcd75
commit
2ab1191f8d
@ -0,0 +1,40 @@
|
|||||||
|
/*
|
||||||
|
* Copyright 2012-2017 the original author or authors.
|
||||||
|
*
|
||||||
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
||||||
|
* you may not use this file except in compliance with the License.
|
||||||
|
* You may obtain a copy of the License at
|
||||||
|
*
|
||||||
|
* http://www.apache.org/licenses/LICENSE-2.0
|
||||||
|
*
|
||||||
|
* Unless required by applicable law or agreed to in writing, software
|
||||||
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
||||||
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||||
|
* See the License for the specific language governing permissions and
|
||||||
|
* limitations under the License.
|
||||||
|
*/
|
||||||
|
|
||||||
|
package org.springframework.boot.web.reactive.context;
|
||||||
|
|
||||||
|
import org.junit.Test;
|
||||||
|
|
||||||
|
import org.springframework.core.io.Resource;
|
||||||
|
|
||||||
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Tests for {@link GenericReactiveWebApplicationContext}
|
||||||
|
*
|
||||||
|
* @author Brian Clozel
|
||||||
|
*/
|
||||||
|
public class GenericReactiveWebApplicationContextTests {
|
||||||
|
|
||||||
|
@Test
|
||||||
|
public void getResourceByPath() throws Exception {
|
||||||
|
GenericReactiveWebApplicationContext context = new GenericReactiveWebApplicationContext();
|
||||||
|
Resource rootResource = context.getResourceByPath("/");
|
||||||
|
assertThat(rootResource.exists()).isFalse();
|
||||||
|
assertThat(rootResource.createRelative("application.properties").exists()).isFalse();
|
||||||
|
}
|
||||||
|
|
||||||
|
}
|
Loading…
Reference in New Issue