Polish "Configure support for GraphQL pagination and sorting"

See gh-34677
pull/34741/head
Andy Wilkinson 2 years ago
parent 7109542e3f
commit 6d5e76e14e

@ -51,6 +51,7 @@ import org.springframework.graphql.data.method.annotation.support.AnnotatedContr
import org.springframework.graphql.data.pagination.ConnectionFieldTypeVisitor; import org.springframework.graphql.data.pagination.ConnectionFieldTypeVisitor;
import org.springframework.graphql.data.pagination.CursorEncoder; import org.springframework.graphql.data.pagination.CursorEncoder;
import org.springframework.graphql.data.pagination.CursorStrategy; import org.springframework.graphql.data.pagination.CursorStrategy;
import org.springframework.graphql.data.pagination.EncodingCursorStrategy;
import org.springframework.graphql.data.query.ScrollPositionCursorStrategy; import org.springframework.graphql.data.query.ScrollPositionCursorStrategy;
import org.springframework.graphql.data.query.SliceConnectionAdapter; import org.springframework.graphql.data.query.SliceConnectionAdapter;
import org.springframework.graphql.data.query.WindowConnectionAdapter; import org.springframework.graphql.data.query.WindowConnectionAdapter;
@ -170,7 +171,7 @@ public class GraphQlAutoConfiguration {
@Bean @Bean
@ConditionalOnMissingBean @ConditionalOnMissingBean
CursorStrategy<ScrollPosition> cursorStrategy() { EncodingCursorStrategy<ScrollPosition> cursorStrategy() {
return CursorStrategy.withEncoder(new ScrollPositionCursorStrategy(), CursorEncoder.base64()); return CursorStrategy.withEncoder(new ScrollPositionCursorStrategy(), CursorEncoder.base64());
} }

@ -44,7 +44,6 @@ import org.springframework.core.io.ByteArrayResource;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.graphql.ExecutionGraphQlService; import org.springframework.graphql.ExecutionGraphQlService;
import org.springframework.graphql.data.method.annotation.support.AnnotatedControllerConfigurer; import org.springframework.graphql.data.method.annotation.support.AnnotatedControllerConfigurer;
import org.springframework.graphql.data.pagination.CursorStrategy;
import org.springframework.graphql.data.pagination.EncodingCursorStrategy; import org.springframework.graphql.data.pagination.EncodingCursorStrategy;
import org.springframework.graphql.execution.BatchLoaderRegistry; import org.springframework.graphql.execution.BatchLoaderRegistry;
import org.springframework.graphql.execution.DataFetcherExceptionResolver; import org.springframework.graphql.execution.DataFetcherExceptionResolver;
@ -65,14 +64,11 @@ class GraphQlAutoConfigurationTests {
@Test @Test
void shouldContributeDefaultBeans() { void shouldContributeDefaultBeans() {
this.contextRunner.run((context) -> { this.contextRunner.run((context) -> assertThat(context).hasSingleBean(GraphQlSource.class)
assertThat(context).hasSingleBean(GraphQlSource.class) .hasSingleBean(BatchLoaderRegistry.class)
.hasSingleBean(BatchLoaderRegistry.class) .hasSingleBean(ExecutionGraphQlService.class)
.hasSingleBean(ExecutionGraphQlService.class) .hasSingleBean(AnnotatedControllerConfigurer.class)
.hasSingleBean(AnnotatedControllerConfigurer.class) .hasSingleBean(EncodingCursorStrategy.class));
.hasSingleBean(CursorStrategy.class);
assertThat(context.getBean(CursorStrategy.class)).isInstanceOf(EncodingCursorStrategy.class);
});
} }
@Test @Test

Loading…
Cancel
Save