Tune expected exceptions to support more platforms

It appears that some machines break when looking for ConnectionException,
but not SocketException, both of which are IOExceptions. This seems to make
tests pass on more machines without compromising the intentions of the API.

[BS-162]
pull/5/merge
Greg Turnquist 12 years ago committed by Phillip Webb
parent 19c2a076c2
commit 9ab2f98df0

@ -16,7 +16,7 @@
package org.springframework.bootstrap.actuate.autoconfigure; package org.springframework.bootstrap.actuate.autoconfigure;
import java.io.FileNotFoundException; import java.io.FileNotFoundException;
import java.net.ConnectException; import java.net.SocketException;
import java.net.URI; import java.net.URI;
import java.nio.charset.Charset; import java.nio.charset.Charset;
@ -49,6 +49,7 @@ import static org.junit.Assert.assertThat;
* Tests for {@link EndpointWebMvcAutoConfiguration}. * Tests for {@link EndpointWebMvcAutoConfiguration}.
* *
* @author Phillip Webb * @author Phillip Webb
* @author Greg Turnquist
*/ */
public class EndpointWebMvcAutoConfigurationTests { public class EndpointWebMvcAutoConfigurationTests {
@ -170,7 +171,7 @@ public class EndpointWebMvcAutoConfigurationTests {
} }
} catch (Exception ex) { } catch (Exception ex) {
if (expected == null) { if (expected == null) {
if (ConnectException.class.isInstance(ex) if (SocketException.class.isInstance(ex)
|| FileNotFoundException.class.isInstance(ex)) { || FileNotFoundException.class.isInstance(ex)) {
return; return;
} }

@ -18,7 +18,7 @@ package org.springframework.bootstrap.context.embedded;
import java.io.FileWriter; import java.io.FileWriter;
import java.io.IOException; import java.io.IOException;
import java.net.ConnectException; import java.net.SocketException;
import java.net.URI; import java.net.URI;
import java.net.URISyntaxException; import java.net.URISyntaxException;
import java.nio.charset.Charset; import java.nio.charset.Charset;
@ -56,6 +56,7 @@ import static org.mockito.Mockito.mock;
* Base for testing classes that extends {@link AbstractEmbeddedServletContainerFactory}. * Base for testing classes that extends {@link AbstractEmbeddedServletContainerFactory}.
* *
* @author Phillip Webb * @author Phillip Webb
* @author Greg Turnquist
*/ */
public abstract class AbstractEmbeddedServletContainerFactoryTests { public abstract class AbstractEmbeddedServletContainerFactoryTests {
@ -91,8 +92,7 @@ public abstract class AbstractEmbeddedServletContainerFactoryTests {
factory.setPort(0); factory.setPort(0);
this.container = factory this.container = factory
.getEmbeddedServletContainer(exampleServletRegistration()); .getEmbeddedServletContainer(exampleServletRegistration());
this.thrown.expect(ConnectException.class); this.thrown.expect(SocketException.class);
this.thrown.expectMessage("Connection refused");
getResponse("http://localhost:8080/hello"); getResponse("http://localhost:8080/hello");
} }
@ -102,7 +102,7 @@ public abstract class AbstractEmbeddedServletContainerFactoryTests {
this.container = factory this.container = factory
.getEmbeddedServletContainer(exampleServletRegistration()); .getEmbeddedServletContainer(exampleServletRegistration());
this.container.stop(); this.container.stop();
this.thrown.expect(ConnectException.class); this.thrown.expect(SocketException.class);
getResponse("http://localhost:8080/hello"); getResponse("http://localhost:8080/hello");
} }

Loading…
Cancel
Save